Page MenuHomePhabricator

[profile] Factor out logic for mmap'ing merged profile, NFC
ClosedPublic

Authored by vsk on Nov 12 2019, 10:27 AM.

Details

Summary

Split out the logic to get the size of a merged profile and to do a
compatibility check. This can be shared with both the continuous+merging
mode implementation, as well as the runtime-allocated counters
implementation planned for Fuchsia.

Lifted out of D69586.

Diff Detail

Event Timeline

vsk created this revision.Nov 12 2019, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2019, 10:27 AM
phosek accepted this revision.Nov 12 2019, 10:40 AM

LGTM

This revision is now accepted and ready to land.Nov 12 2019, 10:40 AM
phosek added inline comments.Nov 12 2019, 10:40 AM
compiler-rt/lib/profile/InstrProfilingFile.c
173–174

Should we be using /* or /// comments? Right now we seem to be inconsistent.

davidxl accepted this revision.Nov 12 2019, 10:53 AM

/* */ is more common, so perhaps make it consistent to this. lgtm otherwise

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2019, 7:59 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript