Page MenuHomePhabricator

[lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable
ClosedPublic

Authored by teemperor on Nov 11 2019, 2:13 AM.

Details

Summary

swift-lldb currently has to patch the ExpressionKind enum to add support for Swift expressions. If we implement LLVM's RTTI
with a static ID variable instead of a centralised enum we can drop that patch.

Diff Detail

Event Timeline

teemperor created this revision.Nov 11 2019, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2019, 2:13 AM
labath accepted this revision.Nov 11 2019, 2:22 AM

Swift aside, I think it's also good that the generic Expression class does not need to know about the various kinds of expressions that the Clang Expression parser plugin wants to invent.

This revision is now accepted and ready to land.Nov 11 2019, 2:22 AM
This revision was automatically updated to reflect the committed changes.