This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.
ClosedPublic

Authored by tianqing on Nov 4 2019, 2:00 AM.

Details

Summary

974c8b7e2fd introduced a warning for GCC:

llvm-project/clang/include/clang/Sema/Overload.h:835:48: warning: ‘clang::OverloadCandidate::RewriteKind’ is too small to hold all values of ‘enum clang::OverloadCandidateRewriteKind’

OverloadCandidateRewriteKind RewriteKind : 2;

Diff Detail

Event Timeline

tianqing created this revision.Nov 4 2019, 2:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2019, 2:00 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rsmith accepted this revision.Nov 4 2019, 3:14 AM
rsmith added a subscriber: rsmith.

Thanks, this seems fine to me. (It's unfortunate that the combination of MSVC's behavior and GCC's non-disableable warning forces this upon us, but so be it.)

This revision is now accepted and ready to land.Nov 4 2019, 3:14 AM

Can you please land it? These warnings are quite annoying.

This revision was automatically updated to reflect the committed changes.