Page MenuHomePhabricator

Improve Clang's getting involved document and make it more inclusive in wording.
ClosedPublic

Authored by chandlerc on Oct 23 2019, 12:15 PM.

Details

Summary

Working with Meike and others to improve the wording in this document.

Diff Detail

Event Timeline

chandlerc created this revision.Oct 23 2019, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2019, 12:15 PM
Herald added a subscriber: mcrosier. · View Herald Transcript
klimek added inline comments.Oct 23 2019, 12:29 PM
clang/www/get_involved.html
94

Remove "complete" - the explanation afterwards seems sufficient?

107

s/non-trivial/substantial/?

108–109

s/,/and/?

113

Perhaps: a standard-conforming implementation?

115–116

"high-quality diagnostics" is a bit unclear
"rich AST" that seems to imply a lot of domain knowledge

120

s/proper//

chandlerc marked an inline comment as done.

Address feedback from Manuel.

chandlerc marked 3 inline comments as done.

More fixes from Manuel.

chandlerc marked 2 inline comments as done.Oct 23 2019, 12:48 PM

Thanks, updated.

clang/www/get_involved.html
113

Sadly, that goes further than this is trying to go.

While this may be a bit vague, we do at least clarify the particular things we are looking for afterward. Better words are welcome if anyone comes up with them of course.

This revision is now accepted and ready to land.Oct 23 2019, 12:51 PM
Harbormaster completed remote builds in B39967: Diff 226174.
This revision was automatically updated to reflect the committed changes.