Page MenuHomePhabricator

[X86] Only look up boolean reduction cost tables if the reduction is not pairwise.
ClosedPublic

Authored by craig.topper on Wed, Oct 16, 11:29 PM.

Details

Summary

We don't pattern match pairwise shuffles in SelectionDAG. So we
should only return the optimized costs if its not a pairwise
shuffle.

I think SLP vectorizer gives priority to non pairwise shuffle if
the cost is the same. And the look up for reduction intrinsics
passes false for the pairwise flag. I didn't check the loop
vectorizer.

Diff Detail

Event Timeline

craig.topper created this revision.Wed, Oct 16, 11:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Oct 16, 11:29 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
RKSimon accepted this revision.Sat, Oct 26, 6:41 AM

LGTM by inspection

This revision is now accepted and ready to land.Sat, Oct 26, 6:41 AM
This revision was automatically updated to reflect the committed changes.