[llvm-lipo] Add missing cast

[alexander-shaposhnikov]

Summary

Add missing cast (to correctly sum 32-bit integers).

[smeenai]

Is there any way to add a test for this?

[compnerd]

I don't think that generating a file of that size makes sense for the test case. Generating a small file and overwriting the file size would be viable, but in this case, we need to use the file size itself, so that doesn't work either.

[alexander-shaposhnikov]

(committed (r374945))

llvm-lipo.cpp

static void createUniversalBinary(SmallVectorImpl<Slice> &Slices,
 
   stable_sort(Slices);
   SmallVector<MachO::fat_arch, 2> FatArchList = buildFatArchList(Slices);
 
   const bool IsExecutable = any_of(Slices, [](Slice S) {
     return sys::fs::can_execute(S.getBinary()->getFileName());
   });
   const uint64_t OutputFileSize =
-      FatArchList.back().offset + FatArchList.back().size;
+      static_cast<uint64_t>(FatArchList.back().offset) +
+      FatArchList.back().size;
   Expected<std::unique_ptr<FileOutputBuffer>> OutFileOrError =
       FileOutputBuffer::create(OutputFileName, OutputFileSize,
                                IsExecutable ? FileOutputBuffer::F_executable
                                             : 0);
   if (!OutFileOrError)
     reportError(OutputFileName, OutFileOrError.takeError());
   std::unique_ptr<FileOutputBuffer> OutFile = std::move(OutFileOrError.get());
   std::memset(OutFile->getBufferStart(), 0, OutputFileSize);