Page MenuHomePhabricator

[llvm-lipo] Add missing cast
ClosedPublic

Authored by alexshap on Oct 14 2019, 6:06 PM.

Details

Summary

Add missing cast (to correctly sum 32-bit integers).

Diff Detail

Repository
rL LLVM

Event Timeline

alexshap created this revision.Oct 14 2019, 6:06 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptOct 14 2019, 6:06 PM
smeenai accepted this revision.Oct 14 2019, 6:15 PM
smeenai added a reviewer: mtrent.

Is there any way to add a test for this?

This revision is now accepted and ready to land.Oct 14 2019, 6:15 PM
compnerd accepted this revision.Oct 15 2019, 10:09 AM

I don't think that generating a file of that size makes sense for the test case. Generating a small file and overwriting the file size would be viable, but in this case, we need to use the file size itself, so that doesn't work either.

alexshap closed this revision.Oct 15 2019, 1:09 PM

(committed (r374945))