[clang-tools-extra] Fix overzealous linking of dylib to clangTidy

[mgorny]

Summary

Fix accidentally making clangTidy library link to dylib. This causes
libclang.so to also link to dylib which results in duplicate symbols
from shared and static libraries, and effectively to registering
command-line options twice.

Thanks to Sylvestre Ledru for noticing this and tracking it down
to r373786. Fixes PR#43589.

[sylvestre.ledru]

Thanks
It fixed my problem.

Maybe you could improve the doc and/or comment to make this behavior more explicit?

[mgorny]

Sure but what doc? The non-existing one of clang_target_link_libraries?

[sylvestre.ledru]

In that function https://github.com/llvm/llvm-project/blob/5fd467feb813e9999efe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180

[mgorny]

In D68927#1709395, @sylvestre.ledru wrote:

In that function https://github.com/llvm/llvm-project/blob/5fd467feb813e9999efe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180

I'm not really sure what you mean me to say. That it links to clang-cpp? That's pretty much what the code says.

clang-tools-extra/clang-tidy/CMakeLists.txt

add_clang_library(clangTidy
   clangRewrite
   clangSema
   clangSerialization
   clangTooling
   clangToolingCore
   )
 
 if(CLANG_ENABLE_STATIC_ANALYZER)
-  clang_target_link_libraries(clangTidy PRIVATE
+  target_link_libraries(clangTidy PRIVATE
     clangStaticAnalyzerCore
     clangStaticAnalyzerFrontend
   )
 endif()
 
 # Checks.
 # If you add a check, also add it to ClangTidyForceLinker.h in this directory.
 add_subdirectory(android)