Add the Altivec __bool keyword for better gcc compatibility

[seurer]

Summary

To provide better compatibility with gcc I added the bool keyword to the Alitivec support in clang. bool is functionally identical to using bool when declaring vector types. For example:

vector bool char v_bc;
vector bool char v_bc;

clang already supported vector and pixel but was missing __bool for some reason.

For reference: https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/PowerPC-AltiVec_002fVSX-Built-in-Functions.html

[wschmidt]

FYI to other reviewers: This was noted as a deficiency in http://llvm.org/bugs/show_bug.cgi?id=19220.

[hfinkel]

LGTM.

We should, however, as a follow-up, think about normalizing how we print these things in error messages. This example from the regression tests you're adding seems to be an amusing representative:

vector __bool pixel v___bp;          // expected-error {{cannot use '__pixel' with '__vector bool'}}

So the original source has vector and pixel without underscores, and bool with them. The error message prints vector and pixel with underscores, and bool without them. We should probably pick one, or the other, or record whether the original token had underscores or not and print them in a corresponding way. The latter is better, but perhaps more work.

[seurer]

The __vector bool is hardcoded in the message in DiagnosticParseKinds.td. Hmm, there are a whole bunch of other similar ones in there, too.

def err_invalid_vector_decl_spec_combination : Error<

"cannot combine with previous '%0' declaration specifier. "
"'__vector' must be first">;

def err_invalid_pixel_decl_spec_combination : Error<

"'__pixel' must be preceded by '__vector'.  "
"'%0' declaration specifier not allowed here">;

def err_invalid_vector_bool_decl_spec : Error<

"cannot use '%0' with '__vector bool'">;

def err_invalid_vector_double_decl_spec : Error <

"use of 'double' with '__vector' requires VSX support to be enabled (available on the POWER7 or later)">;

def err_invalid_vector_long_double_decl_spec : Error<

"cannot use 'long double' with '__vector'">;

def warn_vector_long_decl_spec_combination : Warning<

"Use of 'long' with '__vector' is deprecated">, InGroup<Deprecated>;

[seurer]

Closing, released in r225664

http://llvm.org/viewvc/llvm-project?view=revision&revision=225664

/home/seurer/llvm/llvm-checkin/tools/clang/include/clang/Basic/TokenKinds.def

 KEYWORD(vec_step                    , KEYOPENCL|KEYALTIVEC)
 
 // Borland Extensions.
 KEYWORD(__pascal                    , KEYALL)
 
 // Altivec Extension.
 KEYWORD(__vector                    , KEYALTIVEC)
 KEYWORD(__pixel                     , KEYALTIVEC)
+KEYWORD(__bool                      , KEYALTIVEC)
 
 // ARM NEON extensions.
 ALIAS("__fp16", half                , KEYALL)
 
 // OpenCL Extension.
 KEYWORD(half                        , HALFSUPPORT)
 
 // Objective-C ARC keywords.

/home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseDecl.cpp

case tok::kw__Decimal128:
                                      DiagID, Policy);
       break;
     case tok::kw___vector:
       isInvalid = DS.SetTypeAltiVecVector(true, Loc, PrevSpec, DiagID, Policy);
       break;
     case tok::kw___pixel:
       isInvalid = DS.SetTypeAltiVecPixel(true, Loc, PrevSpec, DiagID, Policy);
       break;
+    case tok::kw___bool:
+      isInvalid = DS.SetTypeAltiVecBool(true, Loc, PrevSpec, DiagID, Policy);
+      break;
     case tok::kw___unknown_anytype:
       isInvalid = DS.SetTypeSpecType(TST_unknown_anytype, Loc,
                                      PrevSpec, DiagID, Policy);
       break;
 
     // class-specifier:
     case tok::kw_class:
     case tok::kw_struct:
bool Parser::TryAltiVecVectorTokenOutOfLine() {
   case tok::kw_signed:
   case tok::kw_unsigned:
   case tok::kw_void:
   case tok::kw_char:
   case tok::kw_int:
   case tok::kw_float:
   case tok::kw_double:
   case tok::kw_bool:
+  case tok::kw___bool:
   case tok::kw___pixel:
     Tok.setKind(tok::kw___vector);
     return true;
   case tok::identifier:
     if (Next.getIdentifierInfo() == Ident_pixel) {
       Tok.setKind(tok::kw___vector);
       return true;
     }
if (Tok.getIdentifierInfo() == Ident_vector) {
     case tok::kw_signed:
     case tok::kw_unsigned:
     case tok::kw_void:
     case tok::kw_char:
     case tok::kw_int:
     case tok::kw_float:
     case tok::kw_double:
     case tok::kw_bool:
+    case tok::kw___bool:
     case tok::kw___pixel:
       isInvalid = DS.SetTypeAltiVecVector(true, Loc, PrevSpec, DiagID, Policy);
       return true;
     case tok::identifier:
       if (Next.getIdentifierInfo() == Ident_pixel) {
         isInvalid = DS.SetTypeAltiVecVector(true, Loc, PrevSpec, DiagID,Policy);
         return true;
       }

/home/seurer/llvm/llvm-checkin/tools/clang/lib/Parse/ParseTentative.cpp

#include "clang/Basic/TokenKinds.def"
   case tok::kw___cdecl:
   case tok::kw___stdcall:
   case tok::kw___fastcall:
   case tok::kw___thiscall:
   case tok::kw___vectorcall:
   case tok::kw___unaligned:
   case tok::kw___vector:
   case tok::kw___pixel:
+  case tok::kw___bool:
   case tok::kw__Atomic:
   case tok::kw___unknown_anytype:
     return TPResult::False;
 
   default:
     break;
   }
   

/home/seurer/llvm/llvm-checkin/tools/clang/test/Parser/altivec.c

 __vector unsigned short int vv_usi;
 __vector int vv_i;
 __vector signed int vv_sint;
 __vector unsigned int vv_ui;
 __vector float vv_f;
 __vector bool char vv_bc;
 __vector bool short vv_bs;
 __vector bool int vv_bi;
+__vector __bool char vv___bc;
+__vector __bool short vv___bs;
+__vector __bool int vv_bi;
 __vector __pixel vv_p;
 __vector pixel vv__p;
 __vector int vf__r();
 void vf__a(__vector int a);
 void vf__a2(int b, __vector int a);
 
 vector char v_c;
 vector signed char v_sc;
 vector unsigned char v_uc;
 vector short v_s;
 vector signed  short v_ss;
 vector unsigned  short v_us;
 vector short int v_si;
 vector signed short int v_ssi;
 vector unsigned short int v_usi;
 vector int v_i;
 vector signed int v_sint;
 vector unsigned int v_ui;
 vector float v_f;
 vector bool char v_bc;
 vector bool short v_bs;
 vector bool int v_bi;
+vector __bool char v___bc;
+vector __bool short v___bs;
+vector __bool int v___bi;
 vector __pixel v_p;
 vector pixel v__p;
 vector int f__r();
 void f_a(vector int a);
 void f_a2(int b, vector int a);
 
 vector int v = (vector int)(-1);
 
 // These should have warnings.
 __vector long vv_l;                 // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 __vector signed long vv_sl;         // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 __vector unsigned long vv_ul;       // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 __vector long int vv_li;            // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 __vector signed long int vv_sli;    // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 __vector unsigned long int vv_uli;  // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 vector long v_l;                    // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 vector signed long v_sl;            // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 vector unsigned long v_ul;          // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 vector long int v_li;               // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 vector signed long int v_sli;       // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 vector unsigned long int v_uli;     // expected-warning {{Use of 'long' with '__vector' is deprecated}}
 __vector long double  vv_ld;        // expected-error {{cannot use 'long double' with '__vector'}}
 vector long double  v_ld;           // expected-error {{cannot use 'long double' with '__vector'}}
 vector bool v_b;                    // expected-warning {{type specifier missing, defaults to 'int'}}
+vector __bool v___b;                // expected-warning {{type specifier missing, defaults to 'int'}}
 
 // These should have errors.
 __vector double vv_d1;               // expected-error {{use of 'double' with '__vector' requires VSX support to be enabled (available on the POWER7 or later)}}
 vector double v_d2;                  // expected-error {{use of 'double' with '__vector' requires VSX support to be enabled (available on the POWER7 or later)}}
 __vector long double  vv_ld3;        // expected-error {{cannot use 'long double' with '__vector'}}
 vector long double  v_ld4;           // expected-error {{cannot use 'long double' with '__vector'}}
 vector bool float v_bf;              // expected-error {{cannot use 'float' with '__vector bool'}}
 vector bool double v_bd;             // expected-error {{cannot use 'double' with '__vector bool'}}
 vector bool pixel v_bp;              // expected-error {{cannot use '__pixel' with '__vector bool'}}
 vector bool signed char v_bsc;       // expected-error {{cannot use 'signed' with '__vector bool'}}
 vector bool unsigned int v_bsc2;     // expected-error {{cannot use 'unsigned' with '__vector bool'}}
 vector bool long v_bl;               // expected-error {{cannot use 'long' with '__vector bool'}}
 vector bool long long v_bll;         // expected-error {{cannot use 'long long' with '__vector bool'}}
+vector __bool float v___bf;          // expected-error {{cannot use 'float' with '__vector bool'}}
+vector __bool double v___bd;         // expected-error {{cannot use 'double' with '__vector bool'}}
+vector __bool pixel v___bp;          // expected-error {{cannot use '__pixel' with '__vector bool'}}
+vector __bool signed char v___bsc;   // expected-error {{cannot use 'signed' with '__vector bool'}}
+vector __bool unsigned int v___bsc2; // expected-error {{cannot use 'unsigned' with '__vector bool'}}
+vector __bool long v___bl;           // expected-error {{cannot use 'long' with '__vector bool'}}
+vector __bool long long v___bll;     // expected-error {{cannot use 'long long' with '__vector bool'}}
 
 // vector long is deprecated, but vector long long is not.
 vector long long v_ll;
 vector signed long long v_sll;
 vector unsigned long long v_ull;
 
 typedef char i8;
 typedef short i16;