Page MenuHomePhabricator

Fix issue when building with Visual Studio
AbandonedPublic

Authored by tatyana-krasnukha on Oct 9 2019, 11:23 AM.

Details

Reviewers
hhb
Summary

The script failed to make a symlink for liblldb.dll because it tried to find it in build_root__/bin whereas Visual Studio places it in build_root__/Debug/bin (for Debug configuration).

Diff Detail

Repository
rLLDB LLDB

Event Timeline

hhb added a comment.EditedOct 9 2019, 2:07 PM

I think this is caused by D68442. Can you check whether D68728 fixes it?

tatyana-krasnukha added a comment.EditedOct 10 2019, 7:48 AM

Hi Haibo,

Sadly, D68728 doesn't fix the issue. It adds "Debug" to the python path, but the script still tries to find 'liblldb.dll' in the wrong location.

finishSwigPythonLLDB.py
380

This command produces an incorrect path for Visual Studio since it concatenates the root build directory with 'bin/liblldb.dll' bypassing configuration name.

tatyana-krasnukha retitled this revision from Fix build with Visual Studio to Fix issue when building with Visual Studio.Oct 10 2019, 9:12 AM
hhb added inline comments.Oct 10 2019, 1:40 PM
finishSwigPythonLLDB.py
380

Hmm understood. The origin change is reverted in rG958091c209d0. So I don't think this is relevant any more. I'll redo the change. Can you help test that time? I don't have a visual studio...

hhb added inline comments.Oct 10 2019, 2:36 PM
finishSwigPythonLLDB.py
380
tatyana-krasnukha abandoned this revision.Oct 11 2019, 4:58 AM

Fixed by reverting the initial commit.

finishSwigPythonLLDB.py
380

Yes, now it works well

finishSwigPythonLLDB.py
380

Can you help test that time? I don't have a visual studio...

Yes, of course!

BTW, I suppose that '--cmakeBuildConfiguration' option can fix the issue for XCode too.

hhb added inline comments.Oct 11 2019, 11:37 AM
finishSwigPythonLLDB.py
380

It does. But we have some other issue when LLDB_BUILD_FRAMEWORK is enabled.

Sent D68858. Wish it goes well this me. 😊