[FPEnv] Change test to conform to strictfp attribute rules

[kpn]

Summary

This test does not conform to the new strictfp attribute rules. In particular, the function definition is not marked strictfp despite containing a function marked strictfp. Also, if any function call is marked strictfp then all function calls in that function must be marked.

This change to move the one strictfp call to a new properly marked function meets all the new rules.

[spatel]

LGTM - you may want to annotate the title with 'NFC' when committing to indicate this patch doesn't actually change code.

As discussed off-list, we have other release-versioned binary test files for compatibility, and I'm not sure yet how that will be handled.

llvm/test/Bitcode/compatibility.ll

exit:
   select i1 true, i32 0, i32 1
   ; CHECK: select i1 true, i32 0, i32 1
   select <2 x i1> <i1 true, i1 false>, <2 x i8> <i8 2, i8 3>, <2 x i8> <i8 3, i8 2>
   ; CHECK: select <2 x i1> <i1 true, i1 false>, <2 x i8> <i8 2, i8 3>, <2 x i8> <i8 3, i8 2>
 
   call void @f.nobuiltin() builtin
   ; CHECK: call void @f.nobuiltin() #43
 
-  call void @f.strictfp() strictfp
-  ; CHECK: call void @f.strictfp() #44
-
   call fastcc noalias i32* @f.noalias() noinline
   ; CHECK: call fastcc noalias i32* @f.noalias() #12
   tail call ghccc nonnull i32* @f.nonnull() minsize
   ; CHECK: tail call ghccc nonnull i32* @f.nonnull() #7
 
   ret void
 }
 
 define void @instructions.call_musttail(i8* inalloca %val) {
   musttail call void @f.param.inalloca(i8* inalloca %val)
   ; CHECK: musttail call void @f.param.inalloca(i8* inalloca %val)
 
   ret void
 }
 
+define void @instructions.strictfp() #44 {
+  call void @f.strictfp() strictfp
+  ; CHECK: call void @f.strictfp() #44
+
+  ret void
+}
+
 define void @instructions.call_notail() {
   notail call void @f1()
   ; CHECK: notail call void @f1()
 
   ret void
 }
 
 define void @instructions.landingpad() personality i32 -2 {