This is an archive of the discontinued LLVM Phabricator instance.

Differential D68621

[sanitizer_common] Remove OnPrint from Go build.
ClosedPublic

Authored by morehouse on Oct 7 2019, 6:28 PM.

Details

Reviewers
vitalybuka
dvyukov
Commits
rCRT374258: [sanitizer_common] Remove OnPrint from Go build.
rL374258: [sanitizer_common] Remove OnPrint from Go build.
rGda6cb7ba4c73: [sanitizer_common] Remove OnPrint from Go build.
Summary

Go now uses __sanitizer_on_print instead.

Diff Detail

Event Timeline

morehouse created this revision.Oct 7 2019, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2019, 6:28 PM
Harbormaster completed remote builds in B39140: Diff 223717.Oct 7 2019, 10:07 PM
vitalybuka accepted this revision.Oct 9 2019, 2:24 PM
This revision is now accepted and ready to land.Oct 9 2019, 2:24 PM
Closed by commit rGda6cb7ba4c73: [sanitizer_common] Remove OnPrint from Go build. (authored by morehouse). · Explain WhyOct 9 2019, 4:03 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2019, 4:03 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
6 lines

Diff 224194

compiler-rt/lib/sanitizer_common/sanitizer_printf.cpp

Show First 20 Lines • Show All 223 Lines • ▼ Show 20 Lines
static void (*PrintfAndReportCallback)(const char *); static void (*PrintfAndReportCallback)(const char *);
void SetPrintfAndReportCallback(void (*callback)(const char *)) { void SetPrintfAndReportCallback(void (*callback)(const char *)) {
PrintfAndReportCallback = callback; PrintfAndReportCallback = callback;
} }
// Can be overriden in frontend. // Can be overriden in frontend.
#if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS) #if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS)
// Implementation must be defined in frontend. // Implementation must be defined in frontend.
// TODO(morehouse): Remove OnPrint after migrating Go to __sanitizer_on_print.
extern "C" void OnPrint(const char *str);
extern "C" void __sanitizer_on_print(const char *str); extern "C" void __sanitizer_on_print(const char *str);
#else #else
SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_on_print, const char *str) { SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_on_print, const char *str) {
(void)str; (void)str;
} }
#endif #endif
static void CallPrintfAndReportCallback(const char *str) { static void CallPrintfAndReportCallback(const char *str) {
#if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS)
// TODO(morehouse): Remove OnPrint after migrating Go to __sanitizer_on_print.
OnPrint(str);
#endif
__sanitizer_on_print(str); __sanitizer_on_print(str);
if (PrintfAndReportCallback) if (PrintfAndReportCallback)
PrintfAndReportCallback(str); PrintfAndReportCallback(str);
} }
static void NOINLINE SharedPrintfCodeNoBuffer(bool append_pid, static void NOINLINE SharedPrintfCodeNoBuffer(bool append_pid,
char *local_buffer, char *local_buffer,
int buffer_size, int buffer_size,
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines