This is an archive of the discontinued LLVM Phabricator instance.

ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)
ClosedPublic

Authored by aprantl on Oct 7 2019, 3:59 PM.

Diff Detail

Event Timeline

aprantl created this revision.Oct 7 2019, 3:59 PM
labath added inline comments.Oct 8 2019, 8:06 AM
lldb/include/lldb/Utility/ConstString.h
441

You could declare the specific instantiation (DenseMapInfo<ConstString>) as a friend instead of the whole template.

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
2496

It looks like the values for these are coming straight from the object file (aka user input). Are you ok with asserting on "resolvers" like 0xff...ff ?

aprantl abandoned this revision.Oct 8 2019, 9:32 AM

Pavel correctly pointed out that this isn't necessarily correct, because the addresses could conflict with the Tombstone/Empty keys.

aprantl reclaimed this revision.Oct 8 2019, 9:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 8 2019, 9:58 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 9:58 AM