This is an archive of the discontinued LLVM Phabricator instance.

Differential D68602

Split two defines into two lines
Needs RevisionPublic

Authored by randall77 on Oct 7 2019, 3:13 PM.

Details

Reviewers
vitalybuka
Summary

Patch by Keith Randall.

Diff Detail

Event Timeline

randall77 created this revision.Oct 7 2019, 3:13 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 7 2019, 3:13 PM
Herald added subscribers: llvm-commits, Restricted Project, delcypher. · View Herald Transcript
randall77 added a reviewer: vitalybuka.Oct 7 2019, 3:13 PM
vitalybuka added inline comments.Oct 7 2019, 3:26 PM
lib/tsan/go/build.bat
53

you can reaload patches into existing review with "arc diff" command
arc diff [base_rev]
e.g. arc diff HEAD^
or just: arc diff

vitalybuka edited the summary of this revision. (Show Details)Oct 7 2019, 3:51 PM
vitalybuka requested changes to this revision.Oct 7 2019, 4:10 PM

already committed

This revision now requires changes to proceed.Oct 7 2019, 4:10 PM
Harbormaster completed remote builds in B39112: Diff 223672.Oct 7 2019, 10:06 PM

Revision Contents

PathSize
lib/
tsan/
go/
3 lines

Diff 223672

lib/tsan/go/build.bat

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesgcc ^
-I..\.. ^ -I..\.. ^
-I..\..\sanitizer_common ^ -I..\..\sanitizer_common ^
-I..\..\..\include ^ -I..\..\..\include ^
-m64 ^ -m64 ^
-Wall ^ -Wall ^
-fno-exceptions ^ -fno-exceptions ^
-fno-rtti ^ -fno-rtti ^
-DSANITIZER_GO=1 ^ -DSANITIZER_GO=1 ^
-DWINVER=0x0600 -D_WIN32_WINNT=0x0600 ^ -DWINVER=0x0600 ^
-D_WIN32_WINNT=0x0600 ^
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

you can reaload patches into existing review with "arc diff" command
arc diff [base_rev]
e.g. arc diff HEAD^
or just: arc diff

vitalybuka: you can reaload patches into existing review with "arc diff" command arc diff [base_rev] e.g.
-DGetProcessMemoryInfo=K32GetProcessMemoryInfo ^ -DGetProcessMemoryInfo=K32GetProcessMemoryInfo ^
-Wno-error=attributes ^ -Wno-error=attributes ^
-Wno-attributes ^ -Wno-attributes ^
-Wno-format ^ -Wno-format ^
-Wno-maybe-uninitialized ^ -Wno-maybe-uninitialized ^
-DSANITIZER_DEBUG=0 ^ -DSANITIZER_DEBUG=0 ^
-O3 ^ -O3 ^
-fomit-frame-pointer ^ -fomit-frame-pointer ^
-std=c++11 -std=c++11