This is an archive of the discontinued LLVM Phabricator instance.

Differential D68459

[clang-rename] Fix a crash when renaming a class without definition.
ClosedPublic

Authored by hokein on Oct 4 2019, 5:27 AM.

Details

Reviewers
sammccall
Commits
rG5d862c042b52: [clang-rename] Fix a crash when renaming a class without definition.
rL373748: [clang-rename] Fix a crash when renaming a class without definition.
rC373748: [clang-rename] Fix a crash when renaming a class without definition.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Oct 4 2019, 5:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 5:27 AM
Harbormaster completed remote builds in B38994: Diff 223194.Oct 4 2019, 5:27 AM
sammccall accepted this revision.Oct 4 2019, 6:51 AM
This revision is now accepted and ready to land.Oct 4 2019, 6:51 AM
Closed by commit rL373748: [clang-rename] Fix a crash when renaming a class without definition. (authored by hokein). · Explain WhyOct 4 2019, 7:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 7:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
lib/
Tooling/
Refactoring/
Rename/
4 lines
test/
clang-rename/
4 lines

Diff 223216

cfe/trunk/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp

Show First 20 Lines • Show All 96 Lines • ▼ Show 20 Linespublic:
bool VisitClassTemplatePartialSpecializationDecl( bool VisitClassTemplatePartialSpecializationDecl(
const ClassTemplatePartialSpecializationDecl *PartialSpec) { const ClassTemplatePartialSpecializationDecl *PartialSpec) {
PartialSpecs.push_back(PartialSpec); PartialSpecs.push_back(PartialSpec);
return true; return true;
} }
private: private:
void handleCXXRecordDecl(const CXXRecordDecl *RecordDecl) { void handleCXXRecordDecl(const CXXRecordDecl *RecordDecl) {
if (!RecordDecl->getDefinition()) {
USRSet.insert(getUSRForDecl(RecordDecl));
return;
}
RecordDecl = RecordDecl->getDefinition(); RecordDecl = RecordDecl->getDefinition();
if (const auto *ClassTemplateSpecDecl = if (const auto *ClassTemplateSpecDecl =
dyn_cast<ClassTemplateSpecializationDecl>(RecordDecl)) dyn_cast<ClassTemplateSpecializationDecl>(RecordDecl))
handleClassTemplateDecl(ClassTemplateSpecDecl->getSpecializedTemplate()); handleClassTemplateDecl(ClassTemplateSpecDecl->getSpecializedTemplate());
addUSRsOfCtorDtors(RecordDecl); addUSRsOfCtorDtors(RecordDecl);
} }
void handleClassTemplateDecl(const ClassTemplateDecl *TemplateDecl) { void handleClassTemplateDecl(const ClassTemplateDecl *TemplateDecl) {
▲ Show 20 Lines • Show All 161 Lines • Show Last 20 Lines

cfe/trunk/test/clang-rename/ForwardClassDecl.cpp

class Foo; // CHECK: class Bar;
Foo *f(); // CHECK: Bar *f();
// RUN: clang-rename -offset=6 -new-name=Bar %s -- | sed 's,//.*,,' | FileCheck %s