This is an archive of the discontinued LLVM Phabricator instance.

[JITLink] Silence GCC warnings. NFC.
ClosedPublic

Authored by mstorsjo on Oct 4 2019, 12:34 AM.

Details

Summary

Use parentheses in expressions with mixed && and ||. Add unreachable after switch cases.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 4 2019, 12:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 12:34 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
mstorsjo updated this revision to Diff 223171.Oct 4 2019, 1:48 AM
mstorsjo edited the summary of this revision. (Show Details)

Tweak the use of unreachable, to avoid warnings when built with clang.

lhames accepted this revision.Oct 4 2019, 11:22 AM

LGTM! Thanks Martin!

This revision is now accepted and ready to land.Oct 4 2019, 11:22 AM
This revision was automatically updated to reflect the committed changes.