[OpenCL] PR43145: preserve addrspace for class accesses
ClosedPublic
Actions

Authored by svenvh on Oct 3 2019, 9:26 AM.

Details

Reviewers

Commits

rGaf6248cbb9e7: [OpenCL] Preserve addrspace in CGClass (PR43145)
rC375118: [OpenCL] Preserve addrspace in CGClass (PR43145)
rL375118: [OpenCL] Preserve addrspace in CGClass (PR43145)

Summary

PR43145 revealed two places where Clang was attempting to create a
bitcast without considering the address space of class types during
C++ class codegen.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

svenvh created this revision.Oct 3 2019, 9:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 9:26 AM

Herald added subscribers: cfe-commits, yaxunl. · View Herald Transcript

LGTM! Thanks!

This revision is now accepted and ready to land.Oct 17 2019, 4:41 AM

Closed by commit rGaf6248cbb9e7: [OpenCL] Preserve addrspace in CGClass (PR43145) (authored by svenvh). · Explain WhyOct 17 2019, 7:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

CGClass.cpp

7 lines

test/

CodeGenOpenCLCXX/

addrspace-derived-base.cl

30 lines

Diff 225426

View Options

clang/lib/CodeGen/CGClass.cpp