Page MenuHomePhabricator

[libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI
ClosedPublic

Authored by john.brawn on Oct 3 2019, 6:18 AM.

Details

Summary

ARM EHABI unwinding tables only store the start address of each function, so the last function is assumed to cover the entire address space after it. The test picks an address on the stack assuming that it's in no function, but because of the above it's actually resolved to the last function. Fix this by using address 0 instead.

Diff Detail

Event Timeline

john.brawn created this revision.Oct 3 2019, 6:18 AM
compnerd accepted this revision.Oct 3 2019, 9:24 AM

*sigh* I thought it used the size of the function to mark the end of the region. Thanks.

This revision is now accepted and ready to land.Oct 3 2019, 9:24 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 10:01 AM