Revert r371729: lld-link: Make /linkrepro: take a filename, not a directory.
ClosedPublic
Actions

Authored by ruiu on Oct 3 2019, 2:08 AM.

Details

Reviewers

• thakis
mstorsjo

Commits

rLLD373703: Revert r371729: lld-link: Make /linkrepro: take a filename, not a directory.
rG67858244314c: Revert r371729: lld-link: Make /linkrepro: take a filename, not a directory.
rL373703: Revert r371729: lld-link: Make /linkrepro: take a filename, not a directory.

Summary

This reverts commit r371729 because /linkrepro option also exists
in Microsoft link.exe and their linker takes not a filename but a
directory name as an argument for /linkrepro.

Diff Detail

Repository: rL LLVM

Event Timeline

ruiu created this revision.Oct 3 2019, 2:08 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 2:08 AM

Harbormaster completed remote builds in B38936: Diff 222978.Oct 3 2019, 2:09 AM

fix lld/test/COFF/linkrepro-pdb.test

Harbormaster completed remote builds in B38938: Diff 222980.Oct 3 2019, 2:21 AM

Sounds sensible to me.

This revision is now accepted and ready to land.Oct 4 2019, 12:14 AM

Closed by commit rL373703: Revert r371729: lld-link: Make /linkrepro: take a filename, not a directory. (authored by ruiu, committed by ). · Explain WhyOct 4 2019, 12:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			lld/trunk/COFF/Driver.cpp (12 lines)
M			lld/trunk/docs/ReleaseNotes.rst (5 lines)
M			lld/trunk/test/COFF/linkrepro-pdb.test (4 lines)
M			lld/trunk/test/COFF/linkrepro-res.test (2 lines)
M			lld/trunk/test/COFF/linkrepro.test (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	222978	0577a0c		Oct 3 2019, 2:08 AM	★	★
Diff 2	222980	0577a0c	- fix lld/test/COFF/linkrepro-pdb.test	Oct 3 2019, 2:21 AM	★	★
Diff 3	223153	373702	rL373703	Oct 4 2019, 12:27 AM	★	★