Page MenuHomePhabricator

[yaml2obj] - Add a Size tag support for SHT_LLVM_ADDRSIG sections.
ClosedPublic

Authored by grimar on Oct 2 2019, 6:37 AM.

Details

Summary

It allows using "Size" with or without "Content" in YAML descriptions of
SHT_LLVM_ADDRSIG sections.

Depends on D68333.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Oct 2 2019, 6:37 AM

One suggestion. Otherwise, looks good.

test/tools/yaml2obj/elf-llvm-addrsig-section.yaml
237 ↗(On Diff #222819)

Thinking about it, there probably wants to be a test-case for Size == Content, to show that this exact scenario is also allowed.

grimar updated this revision to Diff 222993.Oct 3 2019, 5:36 AM
grimar marked an inline comment as done.
  • Addressed review comment.
This revision is now accepted and ready to land.Oct 3 2019, 6:03 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 8:03 AM