Page MenuHomePhabricator

[CodeExtractor] NFC: Refactor sanity checks into isEligible
ClosedPublic

Authored by hiraditya on Oct 2 2019, 5:56 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hiraditya created this revision.Oct 2 2019, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2019, 5:56 AM

ninja check passed

tejohnson accepted this revision.Oct 2 2019, 6:40 AM

LGTM with one suggestion

llvm/include/llvm/Transforms/Utils/CodeExtractor.h
112 ↗(On Diff #222813)

Update comment to mention varargs checking?

This revision is now accepted and ready to land.Oct 2 2019, 6:40 AM
fhahn accepted this revision.Oct 2 2019, 7:15 AM

Lgtm, with comments addressed, thanks

llvm/lib/Transforms/Utils/CodeExtractor.cpp
541 ↗(On Diff #222813)

nit: variables usually are capitalized. Maybe the refactoring would be a good time to update them

hiraditya updated this revision to Diff 222841.Oct 2 2019, 8:27 AM

addressed comments

This revision was automatically updated to reflect the committed changes.