This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] - Alow Size tag for describing SHT_HASH sections.
ClosedPublic

Authored by grimar on Sep 30 2019, 6:12 AM.

Details

Summary

This is a follow-up for D68085 which allows using "Size"
tag together with "Content" tag or alone.

Diff Detail

Event Timeline

grimar created this revision.Sep 30 2019, 6:12 AM
jhenderson added inline comments.Sep 30 2019, 10:06 AM
lib/ObjectYAML/ELFYAML.cpp
1215

clang-format?

1224

I might rephrase this and the below message as follows:

"Bucket" cannot be used with "Content" or "Size"

test/tools/yaml2obj/elf-hash-section.yaml
149

I'd say "SHT_HASH section" instead of "hash section" mostly to match the phrasing used elsewhere in this test.

173

Ditto

197–198

together then the -> together, the

Trailing full stop missing.

grimar updated this revision to Diff 222580.Oct 1 2019, 3:41 AM
grimar marked 5 inline comments as done.
grimar edited the summary of this revision. (Show Details)
  • Addressed review comments.
This revision is now accepted and ready to land.Oct 1 2019, 5:57 AM
MaskRay accepted this revision.Oct 1 2019, 6:51 AM
MaskRay added inline comments.
lib/ObjectYAML/ELFYAML.cpp
1220

You can delete a pair of ()

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2019, 6:51 AM