This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] - Allow specifying custom Link values for SHT_HASH section.
ClosedPublic

Authored by grimar on Sep 30 2019, 6:12 AM.

Diff Detail

Event Timeline

grimar created this revision.Sep 30 2019, 6:12 AM
grimar edited the summary of this revision. (Show Details)

LGTM, with one suggestion.

test/tools/yaml2obj/elf-hash-section.yaml
154–160

The spacing here isn't lined up like it is in the other ones above. I think it should be something like:

# LINK:      Name: .hash1
# LINK:      Link:
# LINK-SAME:       123

# LINK:      Name: .hash2
# LINK:      Link:
# LINK-SAME:       1
This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2019, 2:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2019, 2:54 AM