The VCTP instruction will calculate the predicate masked based upon the number of elements that need to be processed. I had inserted the sub before the vctp intrinsic and supplied it as the operand, but this is incorrect as the sub is calculating the value for the next iteration.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
test/CodeGen/Thumb2/LowOverheadLoops/basic-tail-pred.ll | ||
---|---|---|
111 ↗ | (On Diff #221479) | Perhaps you can teach me some regexps.... I was expecting: [[REMAINING:%.*]] or [[REMAINING:%.+]] I don't see what we are matching 1 or more times, how we 'eat up' all characters with [^ ]+ |
lib/Target/ARM/MVETailPredication.cpp | ||
---|---|---|
494 ↗ | (On Diff #221479) | Move this comment to the new sub. It refers to the sub, right? |
test/CodeGen/Thumb2/LowOverheadLoops/basic-tail-pred.ll | ||
---|---|---|
111 ↗ | (On Diff #221479) | I understand it as, match anything but not a space - the caret being the not. |
Comment Actions
looks good to me
test/CodeGen/Thumb2/LowOverheadLoops/basic-tail-pred.ll | ||
---|---|---|
111 ↗ | (On Diff #221479) | Ah yes, it matches the beginning of a line, or it's a 'not' inside brackets, which I didn't know... So, yep, that's another way to eat up characters; |