Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Paths
Table of Contents
t
Hide Panel
f
Keyboard Reference
?
Differential
D67844
SSP: [2/3] Refactor an if-dyn_cast chain to switch on opcode. NFC
Closed
Public
Actions
Authored by
probinson
on Sep 20 2019, 10:38 AM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
Restricted Project
Subscribers
arsenm
hiraditya
llvm-commits
wdng
Details
Reviewers
arsenm
Commits
rG76817ab1e104: Merging r373219:
rG527815f5b087: [SSP] [2/3] Refactor an if/dyn_cast chain to switch on opcode. NFC
rL373219: [SSP] [2/3] Refactor an if/dyn_cast chain to switch on opcode. NFC
Summary
The refactor makes the function less cluttered and easier to read IMO.
Diff Detail
Repository
rL LLVM
Event Timeline
probinson
created this revision.
Sep 20 2019, 10:38 AM
Herald
added a project:
Restricted Project
.
·
View Herald Transcript
Sep 20 2019, 10:38 AM
Herald
added a subscriber:
hiraditya
.
·
View Herald Transcript
probinson
added a child revision:
D67845: SSP: [3/3] cmpxchg and addrspacecast can now trigger stack protection
.
Sep 20 2019, 10:45 AM
probinson
added a parent revision:
D67842: SSP: [1/3] revert r363169
.
arsenm
accepted this revision.
Sep 20 2019, 11:45 AM
arsenm
added a subscriber:
arsenm
.
Comment Actions
LGTM
This revision is now accepted and ready to land.
Sep 20 2019, 11:45 AM
Herald
added a subscriber:
wdng
.
·
View Herald Transcript
Sep 20 2019, 11:45 AM
Closed by commit
rL373219: [SSP] [2/3] Refactor an if/dyn_cast chain to switch on opcode. NFC
(authored by
probinson
).
·
Explain Why
Sep 30 2019, 8:08 AM
This revision was automatically updated to reflect the committed changes.