[lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresen

[teemperor]

Summary

We should get the TargetAPI lock here to prevent the process of being destroyed while we are in the function. Thanks Jim for explaining what's going on.

Fixes rdar://54424754

[jingham]

LGTM

lldb/trunk/source/API/SBProcess.cpp

bool SBProcess::IsInstrumentationRuntimePresent(
     InstrumentationRuntimeType type) {
   LLDB_RECORD_METHOD(bool, SBProcess, IsInstrumentationRuntimePresent,
                      (lldb::InstrumentationRuntimeType), type);
 
   ProcessSP process_sp(GetSP());
   if (!process_sp)
     return false;
 
+  std::lock_guard<std::recursive_mutex> guard(
+      process_sp->GetTarget().GetAPIMutex());
+
   InstrumentationRuntimeSP runtime_sp =
       process_sp->GetInstrumentationRuntime(type);
 
   if (!runtime_sp.get())
     return false;
 
   return runtime_sp->IsActive();
 }