Page MenuHomePhabricator

[libunwind] Avoid warning about unused typedef
ClosedPublic

Authored by the_jk on Sep 20 2019, 1:05 AM.

Details

Reviewers
compnerd
krasin
Summary

Move the definition of Elf_Addr typedef to the only place it is used, to avoid:

In file included from /home/the_jk/source/llvm-project/libunwind/src/libunwind.cpp:21:
llvm-project/libunwind/src/AddressSpace.hpp:501:28: warning: unused typedef 'Elf_Addr' [-Wunused-local-typedef]

typedef ElfW(Addr) Elf_Addr;
                           ^

1 warning generated.

when compiling for Android with _LIBUNWIND_ARM_EHABI defined and
_LIBUNWIND_SUPPORT_DWARF_UNWIND not defined.

Diff Detail

Event Timeline

the_jk created this revision.Sep 20 2019, 1:05 AM
compnerd accepted this revision.Sep 20 2019, 8:46 AM

Sure, this seems reasonable.

This revision is now accepted and ready to land.Sep 20 2019, 8:46 AM

I don't have commit access so I'd need someone to push this, thanks.

compnerd closed this revision.Sep 20 2019, 1:44 PM

SVN r372427