Page MenuHomePhabricator

the_jk (Joel Klinghed)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2019, 12:40 AM (11 w, 8 h)

Recent Activity

Fri, Oct 25

the_jk added a comment to D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.

I don't have commit access so I'd need someone to push this, thanks.

Fri, Oct 25, 7:28 AM · Restricted Project
the_jk updated the diff for D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.

Include all of the comment.

Fri, Oct 25, 7:21 AM · Restricted Project
the_jk updated the diff for D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.

Sorry, I somehow missed the reference to findSummaryInModule the first time. Updated diff.

Fri, Oct 25, 12:57 AM · Restricted Project

Oct 13 2019

the_jk added a comment to D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.

Another place that already handles multiple locals with the same GUID is in the same file: bool FunctionImportGlobalProcessing::shouldPromoteLocalToGlobal(), from a comment there:

Oct 13 2019, 3:33 AM · Restricted Project

Oct 11 2019

the_jk updated the diff for D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.

Updated to latest master.

Oct 11 2019, 4:14 PM · Restricted Project

Sep 30 2019

the_jk added a comment to D67592: [Clang] Use -main-file-name for source filename if not set.

Great, thanks again.

Sep 30 2019, 7:29 AM · Restricted Project, Restricted Project

Sep 27 2019

the_jk added a comment to D67592: [Clang] Use -main-file-name for source filename if not set.

I don't have commit access so I'd need someone to push this, thanks.

Sep 27 2019, 11:15 PM · Restricted Project, Restricted Project
the_jk updated the diff for D67592: [Clang] Use -main-file-name for source filename if not set.

Moved ModuleName change to CodeGeneratorImpl as suggested, agree that it seems to fit well there.

Sep 27 2019, 2:57 PM · Restricted Project, Restricted Project

Sep 20 2019

the_jk added a comment to D67804: [libunwind] Avoid warning about unused typedef.

I don't have commit access so I'd need someone to push this, thanks.

Sep 20 2019, 12:51 PM · Restricted Project
the_jk created D67804: [libunwind] Avoid warning about unused typedef.
Sep 20 2019, 1:06 AM · Restricted Project

Sep 15 2019

the_jk added a comment to D67592: [Clang] Use -main-file-name for source filename if not set.

Forgot to link: https://bugs.llvm.org/show_bug.cgi?id=43250

Sep 15 2019, 11:24 AM · Restricted Project, Restricted Project
the_jk created D67592: [Clang] Use -main-file-name for source filename if not set.
Sep 15 2019, 11:08 AM · Restricted Project, Restricted Project

Sep 7 2019

the_jk added a comment to D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.

Bug report: https://bugs.llvm.org/show_bug.cgi?id=43250

Sep 7 2019, 3:08 PM · Restricted Project
the_jk created D67322: [LLD][ThinLTO] Handle GUID collision in import global processing.
Sep 7 2019, 3:04 PM · Restricted Project