Page MenuHomePhabricator

test-release.sh: Don't use chrpath on Solaris
ClosedPublic

Authored by ro on Thu, Sep 12, 2:25 AM.

Details

Summary

When trying to run test-release.sh on Solaris 11.4 for 9.0.0 rc4, I failed initially
because Solaris lacks chrpath. This patch accounts for that and allowed the run to
continue.

However, when its use was introduced back in 2013 r194999, it was justified by a libtool quirk
of emedding build directories in RPATHs. Given that libtool isn't used any longer, one
might instead want to revert that patch instead.

The current version was tested on amd64-pc-solaris2.11 and sparcv9-sun-solaris2.11.

Diff Detail

Repository
rL LLVM

Event Timeline

ro created this revision.Thu, Sep 12, 2:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Sep 12, 2:25 AM
tstellar accepted this revision.Thu, Sep 12, 6:25 AM

LGTM. I think CMake removes the build RPATH when installing, but we'd have to confirm that before removing this code.

This revision is now accepted and ready to land.Thu, Sep 12, 6:25 AM
This revision was automatically updated to reflect the committed changes.