Page MenuHomePhabricator

lld-link: Make Options.td formatting more self-consistent.
ClosedPublic

Authored by thakis on Wed, Sep 11, 12:30 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Wed, Sep 11, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Sep 11, 12:30 PM

The help text for -start-lib and -end-lib matches that in the ELF linker. Please keep those matching by changing it there, too. Also, I think s/library/archive/, so that it matches the naming of -wholearchive.

Thanks for taking a look!

I don't think we should keep flag help texts in sync where it doesn't make sense. "Archive" is posix terminology. It's true that "wholearchive" has "archive" in it, but its help text on msdn is "Include All Library Object Files" :)

I could change "archive" to library in the wholearchive help text if you want.

inglorion accepted this revision.Fri, Sep 13, 1:41 PM

I don't think we should keep flag help texts in sync where it doesn't make sense. "Archive" is posix terminology. It's true that "wholearchive" has "archive" in it, but its help text on msdn is "Include All Library Object Files" :)

Fair enough.

shipit

This revision is now accepted and ready to land.Fri, Sep 13, 1:41 PM
This revision was automatically updated to reflect the committed changes.