This is an archive of the discontinued LLVM Phabricator instance.

Differential D67365

[VectorUtils] Remove unused include. [NFC]
ClosedPublic

Authored by fpetrogalli on Sep 9 2019, 1:05 PM.

Details

Reviewers
fhahn
Commits
rG1c3434543a05: [VectorUtils] Remove unused include. [NFC]
rL371523: [VectorUtils] Remove unused include. [NFC]

Diff Detail

Event Timeline

fpetrogalli created this revision.Sep 9 2019, 1:05 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 9 2019, 1:05 PM
fpetrogalli added a reviewer: fhahn.Sep 9 2019, 1:05 PM
fpetrogalli removed a subscriber: fhahn.
fhahn accepted this revision.Sep 9 2019, 1:19 PM

I *think* getVectorIntrinsicIDForCall uses TargetLibraryInfo. Looks like we are still including TargetLibraryInfo.h through some other path, but we probably could also get rid of that path.

LGTM, but please add a forward declaration of TargetLibraryInfo to VectorUtils.h

This revision is now accepted and ready to land.Sep 9 2019, 1:19 PM
fpetrogalli updated this revision to Diff 219429.Sep 9 2019, 1:47 PM

I have added the forward declaration.

Closed by commit rL371523: [VectorUtils] Remove unused include. [NFC] (authored by fhahn). · Explain WhySep 10 2019, 7:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
include/
llvm/
Analysis/
1 line

Diff 219417

llvm/include/llvm/Analysis/VectorUtils.h

Context not available.
#include "llvm/ADT/MapVector.h" #include "llvm/ADT/MapVector.h"
#include "llvm/Analysis/LoopAccessAnalysis.h" #include "llvm/Analysis/LoopAccessAnalysis.h"
#include "llvm/Analysis/TargetLibraryInfo.h"
#include "llvm/IR/IRBuilder.h" #include "llvm/IR/IRBuilder.h"
#include "llvm/Support/CheckedArithmetic.h" #include "llvm/Support/CheckedArithmetic.h"
Context not available.