This is an archive of the discontinued LLVM Phabricator instance.

[lib/ObjectYAML] - Cleanup the private interface of ELFState<ELFT>. NFCI.
ClosedPublic

Authored by grimar on Sep 4 2019, 5:29 AM.

Details

Summary

In D62809 I accidentally added "ELFState<ELFT> &State" as the
first parameter to two methods. There is no reason for having that.
I removed this argument and also moved finalizeStrings declaration to
remove an excessive 'private:' tag.

Diff Detail

Event Timeline

grimar created this revision.Sep 4 2019, 5:29 AM
grimar edited the summary of this revision. (Show Details)
MaskRay accepted this revision.Sep 5 2019, 1:41 AM

I do not know why, but two methods accepted ELFState<ELFT> &State as

an argument, though they are not static. There is no visible reason for having that.

D62809 accidentally added ELFState<ELFT> &State as the first parameter to two methods. This patch removes them.

This revision is now accepted and ready to land.Sep 5 2019, 1:41 AM
grimar added a comment.Sep 5 2019, 1:44 AM

I do not know why, but two methods accepted ELFState<ELFT> &State as

an argument, though they are not static. There is no visible reason for having that.

D62809 accidentally added ELFState<ELFT> &State as the first parameter to two methods. This patch removes them.

Ah, it was me... :) Fine then.

grimar edited the summary of this revision. (Show Details)Sep 5 2019, 1:55 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2019, 1:58 AM