[lib/ObjectYAML] - Stop calling error(1) when mapping the st_other field of a symbol.

[grimar]

Summary

This eliminates one of the error(1) call in this lib.
It is different from the others because happens on a fields mapping stage
and can be easily fixed.

[grimar]

• Remove ' \n' from the error message.

[grimar]

test/tools/yaml2obj/elf-symbol-stother.yaml

7 ↗

(On Diff #218634)

I am not sure if we want a full stop at the end or not. Looking at the code it seems we are not consistent atm.

[MaskRay]

test/tools/yaml2obj/elf-symbol-stother.yaml

7 ↗

(On Diff #218634)

Since we are already inconsistent, we can probably follow other tools - uncapitalize and remove full stops.

llvm/trunk/lib/ObjectYAML/ELFYAML.cpp

uint8_t toValue(StringRef Name) {
     auto It = Flags.find(Name);
     if (It != Flags.end())
       return It->second;
 
     uint8_t Val;
     if (to_integer(Name, Val))
       return Val;
 
-    llvm::WithColor::error()
-        << "an unknown value is used for symbol's 'Other' field: " << Name
-        << ".\n";
-    exit(1);
+    YamlIO.setError("an unknown value is used for symbol's 'Other' field: " +
+                    Name);
   }
 
   Optional<uint8_t> denormalize(IO &) {
     if (!Other)
       return None;
     uint8_t Ret = 0;
     for (StOtherPiece &Val : *Other)
       Ret |= toValue(Val);
if (EMachine == ELF::EM_MIPS) {
       Map["STO_MIPS_MICROMIPS"] = ELF::STO_MIPS_MICROMIPS;
       Map["STO_MIPS_PIC"] = ELF::STO_MIPS_PIC;
       Map["STO_MIPS_PLT"] = ELF::STO_MIPS_PLT;
       Map["STO_MIPS_OPTIONAL"] = ELF::STO_MIPS_OPTIONAL;
     }
     return Map;
   }
 
-  const IO &YamlIO;
+  IO &YamlIO;
   Optional<std::vector<StOtherPiece>> Other;
   std::string UnknownFlagsHolder;
 };
 
 } // end anonymous namespace
 
 void MappingTraits<ELFYAML::Symbol>::mapping(IO &IO, ELFYAML::Symbol &Symbol) {
   IO.mapOptional("Name", Symbol.Name, StringRef());

llvm/trunk/test/tools/yaml2obj/elf-symbol-stother.yaml

 ## Test how yaml2obj sets the value of a symbol's st_other fields.
 
 ## Show that yaml2obj reports an error when using an STO_* flag that belongs
 ## to a different machine type to what is specified by the YAML.
 
 # RUN: not yaml2obj --docnum=1 2>&1 %s | FileCheck %s --check-prefix=ERR
-# ERR: error: an unknown value is used for symbol's 'Other' field: STO_MIPS_OPTIONAL.
+# ERR: error: an unknown value is used for symbol's 'Other' field: STO_MIPS_OPTIONAL
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS32
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_386
 Symbols: