This is an archive of the discontinued LLVM Phabricator instance.

[lib/ObjectYAML] - Stop calling error(1) when mapping the st_other field of a symbol.
ClosedPublic

Authored by grimar on Sep 4 2019, 3:27 AM.

Diff Detail

Event Timeline

grimar created this revision.Sep 4 2019, 3:27 AM
grimar updated this revision to Diff 218634.Sep 4 2019, 3:31 AM
  • Remove ' \n' from the error message.
grimar marked an inline comment as done.Sep 4 2019, 3:33 AM
grimar added inline comments.
test/tools/yaml2obj/elf-symbol-stother.yaml
7 ↗(On Diff #218634)

I am not sure if we want a full stop at the end or not. Looking at the code it seems we are not consistent atm.

MaskRay accepted this revision.Sep 4 2019, 3:49 AM
MaskRay added inline comments.
test/tools/yaml2obj/elf-symbol-stother.yaml
7 ↗(On Diff #218634)

Since we are already inconsistent, we can probably follow other tools - uncapitalize and remove full stops.

This revision is now accepted and ready to land.Sep 4 2019, 3:49 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2019, 1:27 AM