Fix argument order for BugType instation for

[rtmpdavid]

Summary

There is a mixup in this specific one, name and category are in incorrect order

[MTC]

Good catch, the fix is reasonable to me. However, I'm no longer wok on the analyzer now, maybe you can add @NoQ Or some other active reviewers to review the code.

[NoQ]

Ah, the good old "stringly typed" APIs.

Would you like to write a LIT test for the fix, say by FileChecking the Plist output? (i could write one for you if it's not your cup of tea)

[MTC]

Hi @NoQ, sorry to bother you. This patch has been on hold for a very long time. It should not have been fixed yet. What's next? Abandon the patch, or improve it yourself?

clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

 void CStringChecker::emitOverlapBug(CheckerContext &C, ProgramStateRef state,
                                   const Stmt *First, const Stmt *Second) const {
   ExplodedNode *N = C.generateErrorNode(state);
   if (!N)
     return;
 
   if (!BT_Overlap)
     BT_Overlap.reset(new BugType(Filter.CheckNameCStringBufferOverlap,
-                                 categories::UnixAPI, "Improper arguments"));
+                                 "Improper arguments", categories::UnixAPI));
 
   // Generate a report for this bug.
   auto report = std::make_unique<BugReport>(
       *BT_Overlap, "Arguments must not be overlapping buffers", N);
   report->addRange(First->getSourceRange());
   report->addRange(Second->getSourceRange());
 
   C.emitReport(std::move(report));