This is an archive of the discontinued LLVM Phabricator instance.

Differential D67145

Add .git-blame-ignore-revs file
ClosedPublic

Authored by ruiu on Sep 3 2019, 11:55 PM.

Details

Reviewers
MaskRay
Commits
rG17de54529384: Add .git-blame-ignore-revs file
rL370855: Add .git-blame-ignore-revs file
Summary

This new file is intended to be used to list sweeping changes
such as mass reformatting or renaming. You can configure git-blame
so that the command ignores commits listed in this file.

The initial contents of this file is two commit hashes which did
mass renaming to the lld directory.

Diff Detail

Event Timeline

ruiu created this revision.Sep 3 2019, 11:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2019, 11:55 PM
Harbormaster completed remote builds in B37693: Diff 218597.Sep 3 2019, 11:56 PM
MaskRay added inline comments.Sep 4 2019, 1:46 AM
.git-blame-ignore-revs
12

I currently use .git/blame. Is .git-blame-ignore-revs recognized by default as well?

You may add comments beside commit ids to mark the revision numbers, and probably titles.

ruiu marked an inline comment as done.Sep 4 2019, 1:51 AM
ruiu added inline comments.
.git-blame-ignore-revs
12

No, git blame doesn't use any file by default. I borrowed this filename from git-hyper-blame, which is a 3rd party extension that implements the feature before git blame acquires this feature last month.

ruiu updated this revision to Diff 218612.Sep 4 2019, 1:54 AM
  • add a comment to each commit
Harbormaster completed remote builds in B37699: Diff 218612.Sep 4 2019, 1:54 AM
MaskRay accepted this revision.Sep 4 2019, 2:06 AM
MaskRay added inline comments.
.git-blame-ignore-revs
12

It looks this file has been adopted by several projects: firefox, chrome, etc. This is nice.

This revision is now accepted and ready to land.Sep 4 2019, 2:06 AM
Closed by commit rL370855: Add .git-blame-ignore-revs file (authored by ruiu). · Explain WhySep 4 2019, 2:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
15 lines

Diff 218612

.git-blame-ignore-revs

  • This file was added.
# Since version 2.23 (released in August 2019), git-blame has a feature
# to ignore or bypass certain commits.
#
# This file contains a list of commits that are not likely what you
# are looking for in a blame, such as mass reformatting or renaming.
# You can set this file as a default ignore file for blame by running
# the following command.
#
# $ git config blame.ignoreRevsFile .git-blame-ignore-revs
# r365730: [Coding style change][lld] Rename variables for non-ELF ports
136d27ab4de0c1d5dedfecc32a9857be78fa0648
MaskRayUnsubmitted
Not Done
ReplyInline Actions

I currently use .git/blame. Is .git-blame-ignore-revs recognized by default as well?

You may add comments beside commit ids to mark the revision numbers, and probably titles.

MaskRay: I currently use `.git/blame`. Is .git-blame-ignore-revs recognized by default as well? You may…
ruiuAuthorUnsubmitted
Done
ReplyInline Actions

No, git blame doesn't use any file by default. I borrowed this filename from git-hyper-blame, which is a 3rd party extension that implements the feature before git blame acquires this feature last month.

ruiu: No, `git blame` doesn't use any file by default. I borrowed this filename from git-hyper-blame…
MaskRayUnsubmitted
Not Done
ReplyInline Actions

It looks this file has been adopted by several projects: firefox, chrome, etc. This is nice.

MaskRay: It looks this file has been adopted by several projects: firefox, chrome, etc. This is nice.
# r365595: [Coding style change] Rename variables so that they start with a lowercase letter
3837f4273fcc40cc519035479aefe78e5cbd3055