This is an archive of the discontinued LLVM Phabricator instance.

Differential D67103

[cmake] Remove MSVC C4180 override
ClosedPublic

Authored by RKSimon on Sep 3 2019, 8:37 AM.

Download Raw Diff

Details

Reviewers

rnk

Commits

rGd3e3c11f4bcc: [cmake] Remove MSVC C4180 override
rL370871: [cmake] Remove MSVC C4180 override

Summary

Tested on VS2017 and VS2019 llvm/clang builds with WX enabled - its no longer necessary to disable this warning.

Diff Detail

Repository: rL LLVM

Event Timeline

RKSimon created this revision.Sep 3 2019, 8:37 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2019, 8:37 AM

Herald added a subscriber: mgorny. · View Herald Transcript

lgtm

This revision is now accepted and ready to land.Sep 3 2019, 10:11 AM

Closed by commit rL370871: [cmake] Remove MSVC C4180 override (authored by RKSimon). · Explain WhySep 4 2019, 3:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cmake/

modules/

	HandleLLVMOptions.cmake
	HandleLLVMOptions.cmake (revision 370748)

1 line

Diff 218462

cmake/modules/HandleLLVMOptions.cmake

	Show First 20 Lines • Show All 496 Lines • ▼ Show 20 Lines
	endif( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )			endif( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )

	if (MSVC)			if (MSVC)
	if (NOT CLANG_CL)			if (NOT CLANG_CL)
	set(msvc_warning_flags			set(msvc_warning_flags
	# Disabled warnings.			# Disabled warnings.
	-wd4141 # Suppress ''modifier' : used more than once' (because of __forceinline combined with inline)			-wd4141 # Suppress ''modifier' : used more than once' (because of __forceinline combined with inline)
	-wd4146 # Suppress 'unary minus operator applied to unsigned type, result still unsigned'			-wd4146 # Suppress 'unary minus operator applied to unsigned type, result still unsigned'
	-wd4180 # Suppress 'qualifier applied to function type has no meaning; ignored'
	-wd4244 # Suppress ''argument' : conversion from 'type1' to 'type2', possible loss of data'			-wd4244 # Suppress ''argument' : conversion from 'type1' to 'type2', possible loss of data'
	-wd4258 # Suppress ''var' : definition from the for loop is ignored; the definition from the enclosing scope is used'			-wd4258 # Suppress ''var' : definition from the for loop is ignored; the definition from the enclosing scope is used'
	-wd4267 # Suppress ''var' : conversion from 'size_t' to 'type', possible loss of data'			-wd4267 # Suppress ''var' : conversion from 'size_t' to 'type', possible loss of data'
	-wd4291 # Suppress ''declaration' : no matching operator delete found; memory will not be freed if initialization throws an exception'			-wd4291 # Suppress ''declaration' : no matching operator delete found; memory will not be freed if initialization throws an exception'
	-wd4345 # Suppress 'behavior change: an object of POD type constructed with an initializer of the form () will be default-initialized'			-wd4345 # Suppress 'behavior change: an object of POD type constructed with an initializer of the form () will be default-initialized'
	-wd4351 # Suppress 'new behavior: elements of array 'array' will be default initialized'			-wd4351 # Suppress 'new behavior: elements of array 'array' will be default initialized'
	-wd4456 # Suppress 'declaration of 'var' hides local variable'			-wd4456 # Suppress 'declaration of 'var' hides local variable'
	-wd4457 # Suppress 'declaration of 'var' hides function parameter'			-wd4457 # Suppress 'declaration of 'var' hides function parameter'
	▲ Show 20 Lines • Show All 472 Lines • Show Last 20 Lines