This is an archive of the discontinued LLVM Phabricator instance.

Differential D67069

[llvm-strings][test] Merge two closely-related tests
ClosedPublic

Authored by jhenderson on Sep 2 2019, 3:24 AM.

Details

Reviewers
grimar
Commits
rG43e9ead1edde: [llvm-strings][test] Merge two closely related tests
rL370643: [llvm-strings][test] Merge two closely related tests
Summary

This is a follow-up to feedback on D66015.

Diff Detail

Event Timeline

jhenderson created this revision.Sep 2 2019, 3:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2019, 3:25 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
grimar accepted this revision.Sep 2 2019, 3:39 AM

LGTM

llvm/test/tools/llvm-strings/eof.test
11

NOPRINT-NOT: {{.}} would probably be a bit better?

This revision is now accepted and ready to land.Sep 2 2019, 3:39 AM
jhenderson marked an inline comment as done.Sep 2 2019, 4:26 AM
jhenderson added inline comments.
llvm/test/tools/llvm-strings/eof.test
11

Yes, I was thinking about that when I did this. I'll update before committing.

Closed by commit rL370643: [llvm-strings][test] Merge two closely related tests (authored by jhenderson). · Explain WhySep 2 2019, 4:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-strings/
10 lines

Diff 218321

llvm/test/tools/llvm-strings/eof-no-string.test

  • This file was deleted.
## Show that llvm-strings does not print the last string in the input if it is
## too short and no unprintable character follows it.
RUN: echo -n abc | llvm-strings - | FileCheck --allow-empty %s
CHECK-NOT: abc

llvm/test/tools/llvm-strings/eof.test

## Show that llvm-strings prints the last string in the input even if no ## Show that llvm-strings prints the last string in the input even if no
## unprintable character follows it. ## unprintable character follows it.
RUN: echo -n abcdefg | llvm-strings - | FileCheck %s RUN: echo -n abcdefg | llvm-strings - | FileCheck %s --check-prefix=PRINT
CHECK: abcdefg PRINT: abcdefg
## Show that llvm-strings does not print the last string in the input if it is
## too short and no unprintable character follows it.
RUN: echo -n abc | llvm-strings - | FileCheck --allow-empty %s --check-prefix=NOPRINT
NOPRINT-NOT: abc
grimarUnsubmitted
Not Done
ReplyInline Actions

NOPRINT-NOT: {{.}} would probably be a bit better?

grimar: `NOPRINT-NOT: {{.}}` would probably be a bit better?
jhendersonAuthorUnsubmitted
Done
ReplyInline Actions

Yes, I was thinking about that when I did this. I'll update before committing.

jhenderson: Yes, I was thinking about that when I did this. I'll update before committing.