This is an archive of the discontinued LLVM Phabricator instance.

Do not define CRT_HAS_128BIT for MIPS64
ClosedPublic

Authored by petarj on Dec 17 2014, 6:19 AM.

Details

Summary

Do not define it for MIPS64 until its backend supports it.
See the bug report [1] for more information.

[1] http://llvm.org/bugs/show_bug.cgi?id=20098

Diff Detail

Repository
rL LLVM

Event Timeline

petarj updated this revision to Diff 17388.Dec 17 2014, 6:19 AM
petarj retitled this revision from to Do not define CRT_HAS_128BIT for MIPS64.
petarj updated this object.
petarj edited the test plan for this revision. (Show Details)
petarj added a reviewer: joerg.
petarj added a subscriber: Unknown Object (MLST).
joerg accepted this revision.Dec 17 2014, 6:27 AM
joerg edited edge metadata.

With the change, LGTM.

lib/builtins/int_types.h
59 ↗(On Diff #17388)

Add a comment with the bug reference here please (i.e. MIPS64 issue: PR 20098).

This revision is now accepted and ready to land.Dec 17 2014, 6:27 AM
joerg added inline comments.Dec 17 2014, 9:37 AM
lib/builtins/int_types.h
59 ↗(On Diff #17388)

I think this should also be restricted to clang, GCC works fine, doesn't it?

petarj updated this revision to Diff 17415.Dec 17 2014, 5:15 PM
petarj edited edge metadata.
petarj added inline comments.
lib/builtins/int_types.h
59 ↗(On Diff #17388)

Done.
Yes, it's clang only. I have just updated the patch.

This revision was automatically updated to reflect the committed changes.