This is an archive of the discontinued LLVM Phabricator instance.

Do not define CRT_HAS_128BIT for MIPS64
ClosedPublic

Authored by petarj on Dec 17 2014, 6:19 AM.

Reviewers

Commits

Summary

Do not define it for MIPS64 until its backend supports it.
See the bug report [1] for more information.

petarj retitled this revision from to Do not define CRT_HAS_128BIT for MIPS64.

petarj updated this object.

petarj edited the test plan for this revision. (Show Details)

petarj added a reviewer: joerg.

petarj added a subscriber: Unknown Object (MLST).

With the change, LGTM.

lib/builtins/int_types.h
59–60	Add a comment with the bug reference here please (i.e. MIPS64 issue: PR 20098).

This revision is now accepted and ready to land.Dec 17 2014, 6:27 AM

lib/builtins/int_types.h
59–60	I think this should also be restricted to clang, GCC works fine, doesn't it?

petarj edited edge metadata.

petarj added inline comments.

lib/builtins/int_types.h
59–60	Done. Yes, it's clang only. I have just updated the patch.

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

builtins/

3 lines

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	#if _YUGA_LITTLE_ENDIAN
su_int high;		su_int high;
#else		#else
su_int high;		su_int high;
su_int low;		su_int low;
#endif /* _YUGA_LITTLE_ENDIAN */		#endif /* _YUGA_LITTLE_ENDIAN */
}s;		}s;
} udwords;		} udwords;

#if __LP64__		/* MIPS64 issue: PR 20098 */
		#if defined(__LP64__) && !(defined(__mips__) && defined(__clang__))
		joergUnsubmitted Not Done Reply Inline Actions Add a comment with the bug reference here please (i.e. MIPS64 issue: PR 20098). joerg: Add a comment with the bug reference here please (i.e. MIPS64 issue: PR 20098).
		joergUnsubmitted Not Done Reply Inline Actions I think this should also be restricted to clang, GCC works fine, doesn't it? joerg: I think this should also be restricted to __clang__, GCC works fine, doesn't it?
		petarjAuthorUnsubmitted Not Done Reply Inline Actions Done. Yes, it's clang only. I have just updated the patch. petarj: Done. Yes, it's clang only. I have just updated the patch.
#define CRT_HAS_128BIT		#define CRT_HAS_128BIT
#endif		#endif

#ifdef CRT_HAS_128BIT		#ifdef CRT_HAS_128BIT
typedef int ti_int __attribute__ ((mode (TI)));		typedef int ti_int __attribute__ ((mode (TI)));
typedef unsigned tu_int __attribute__ ((mode (TI)));		typedef unsigned tu_int __attribute__ ((mode (TI)));

typedef union		typedef union
▲ Show 20 Lines • Show All 76 Lines • Show Last 20 Lines