This is an archive of the discontinued LLVM Phabricator instance.

Allow '@' to appear in x86 mingw symbols
ClosedPublic

Authored by rnk on Aug 29 2019, 2:01 PM.

Details

Summary

There is no reason to differ in assembler behavior here between -msvc
and -gnu targets. Without this setting, the text after the '@' is
interpreted as a symbol variable, like foo@IMGREL.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Aug 29 2019, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 2:01 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
mstorsjo accepted this revision.Aug 29 2019, 2:03 PM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 29 2019, 2:03 PM
This revision was automatically updated to reflect the committed changes.