Page MenuHomePhabricator

[lldb][NFC] Remove TestFormats.py as is tests nothing
AbandonedPublic

Authored by teemperor on Aug 29 2019, 10:16 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This test tests nothing as it just creates a target and runs to main. It's also using pexpect
and its documentation and name don't fit its content.

Diff Detail

Event Timeline

teemperor created this revision.Aug 29 2019, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 10:16 AM

Does anybody know what this was supposed to test?

teemperor abandoned this revision.Aug 29 2019, 10:22 AM

D66954 ninja'd this patch :(

@jingham In D66954, Pavel digs into the history of the test a bit.

That was the only test that tested the "command regex" functionality. It was probably called TestFormats.py because somebody copied over a test without changing the file name since that name makes no sense.

labath added a subscriber: labath.Aug 30 2019, 1:59 AM

Actually, it looks like this test was committed with the regex stuff already being commented out (back in 2015/r228207), so the test never really tested anything..