[dotest] Make dotest.py invocation repeatable

[JDevlieghere]

Summary

This removes support for reading the LLDB_TEST_ARGUMENTS environment variable and instead requires all arguments to be specified as part of the invocation. This ensures that dotest.py invocations are easily repeatable.

lldb/trunk/packages/Python/lldbsuite/test/dotest.py

 from . import dotest_args
 from . import lldbtest_config
 from . import test_categories
 from lldbsuite.test_event import formatter
 from . import test_result
 from lldbsuite.test_event.event_builder import EventBuilder
 from ..support import seven
 
+def get_dotest_invocation():
+    return ' '.join(sys.argv)
+
 
 def is_exe(fpath):
     """Returns true if fpath is an executable."""
     if fpath == None:
       return False
     return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
 
 
def parseOptionsAndInitTestdirs():
 
     do_help = False
 
     platform_system = platform.system()
     platform_machine = platform.machine()
 
     try:
         parser = dotest_args.create_parser()
-        args = dotest_args.parse_args(parser, sys.argv[1:])
+        args = parser.parse_args()
     except:
-        print(' '.join(sys.argv))
+        print(get_dotest_invocation())
         raise
 
     if args.unset_env_varnames:
         for env_var in args.unset_env_varnames:
             if env_var in os.environ:
                 # From Python Doc: When unsetenv() is supported, deletion of items in os.environ
                 # is automatically translated into a corresponding call to
                 # unsetenv().
                 del os.environ[env_var]
                 # os.unsetenv(env_var)
 
     if args.set_env_vars:
         for env_var in args.set_env_vars:
             parts = env_var.split('=', 1)
             if len(parts) == 1:
                 os.environ[parts[0]] = ""
             else:
                 os.environ[parts[0]] = parts[1]
 
     if args.set_inferior_env_vars:
         lldbtest_config.inferior_env = ' '.join(args.set_inferior_env_vars)
 
     # Only print the args if being verbose.
     if args.v and not args.q:
-        print(sys.argv)
+        print(get_dotest_invocation())
 
     if args.h:
         do_help = True
 
     if args.compiler:
         configuration.compiler = os.path.realpath(args.compiler)
         if not is_exe(configuration.compiler):
             configuration.compiler = which(args.compiler)
if ("GDB_REMOTE_LOG" in os.environ):
             "log enable -n -f " + os.environ["GDB_REMOTE_LOG"] + " gdb-remote "
             + gdb_remote_log_option,
             res)
         if not res.Succeeded():
             raise Exception(
                 'log enable failed (check GDB_REMOTE_LOG env variable)')
 
 
-def getMyCommandLine():
-    return ' '.join(sys.argv)
-
 # ======================================== #
 #                                          #
 # Execution of the test driver starts here #
 #                                          #
 # ======================================== #
 
 
 def checkDsymForUUIDIsNotOn():
def run_suite():
 
     lldbutil.mkdir_p(configuration.sdir_name)
     os.environ["LLDB_SESSION_DIRNAME"] = configuration.sdir_name
 
     sys.stderr.write(
         "\nSession logs for test failures/errors/unexpected successes"
         " will go into directory '%s'\n" %
         configuration.sdir_name)
-    sys.stderr.write("Command invoked: %s\n" % getMyCommandLine())
+    sys.stderr.write("Command invoked: %s\n" % get_dotest_invocation())
 
     #
     # Invoke the default TextTestRunner to run the test suite
     #
     checkCompiler()
 
     if configuration.verbose:
         print("compiler=%s" % configuration.compiler)

lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py

 from __future__ import print_function
 from __future__ import absolute_import
 
 # System modules
 import argparse
 import sys
 import os
 import textwrap
 
-# Third-party modules
-
 # LLDB modules
 from . import configuration
 
 
-class ArgParseNamespace(object):
-    pass
-
-
-def parse_args(parser, argv):
-    """ Returns an argument object. LLDB_TEST_ARGUMENTS environment variable can
-        be used to pass additional arguments.
-    """
-    args = ArgParseNamespace()
-
-    if ('LLDB_TEST_ARGUMENTS' in os.environ):
-        print(
-            "Arguments passed through environment: '%s'" %
-            os.environ['LLDB_TEST_ARGUMENTS'])
-        args = parser.parse_args([sys.argv[0]].__add__(
-            os.environ['LLDB_TEST_ARGUMENTS'].split()), namespace=args)
-
-    return parser.parse_args(args=argv, namespace=args)
-
-
 def create_parser():
     parser = argparse.ArgumentParser(
         description='description',
         prefix_chars='+-',
         add_help=False)
     group = None
 
     # Helper function for boolean options (group will point to the current