Page MenuHomePhabricator

[libomptarget] Refactor syncthreads macro to inline function
AbandonedPublic

Authored by JonChesterfield on Aug 27 2019, 6:16 PM.

Details

Summary

[libomptarget] Refactor syncthreads macro to inline function
See also abandoned D66846, split into this diff and others.

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2019, 6:16 PM
ABataev added inline comments.Aug 27 2019, 6:25 PM
openmp/libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
555–556

Remove FIXME

569–570

And here too

openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu
128–129

Remove FIXME

170–171

Same here

openmp/libomptarget/deviceRTLs/nvptx/src/sync.cu
77–78

Same

openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
51

#endif // __clang__

Thanks. I wasn't sure whether to leave the FIXMEs in place or not, will drop them.

  • remove fixme, add comment, rebase on master
JonChesterfield abandoned this revision.Aug 27 2019, 7:14 PM

Phabricator has decided to mix this patch in with the other patches that have landed on master since initially creating it. Presumably my mistake for rebasing. I'll abandon this and create a new diff. Sorry for the noise.