Page MenuHomePhabricator

[polly][NFC] Compute WAR dependence info using ISL kills
ClosedPublic

Authored by bin.narwal on Aug 26 2019, 6:59 AM.

Details

Summary

Hi,
When reading code of Dependences::calculateDependences, I noticed that WAR is computed specifically by
buildWAR. Given ISL now supports "kills" in approximate dataflow analysis, this patch takes advantage of it.
Though I don't know if it's intended not using the ISL "kills" functionality.

This patch also cleans up a couple lines redundant codes. Any comments?

Thanks,

Diff Detail

Repository
rL LLVM

Event Timeline

bin.narwal created this revision.Aug 26 2019, 6:59 AM
lebedev.ri retitled this revision from Compute WAR dependence info using ISL kills to [polly] Compute WAR dependence info using ISL kills.Aug 26 2019, 7:18 AM
Meinersbur accepted this revision.Aug 26 2019, 2:01 PM

LGTM. Please add "NFC" to the title for "No Functional Change" intended.

Please add a message if/when I can commit this for you.

lib/Analysis/DependenceInfo.cpp
289–291 ↗(On Diff #217137)

[nit] It would be nice to keep the union_map's together and have schedule as the last argument.

This revision is now accepted and ready to land.Aug 26 2019, 2:01 PM
bin.narwal marked an inline comment as done.
bin.narwal retitled this revision from [polly] Compute WAR dependence info using ISL kills to [polly][NFC] Compute WAR dependence info using ISL kills.

Hi Michael, thanks for reviewing. I updated the diff according to your comments.
And yes, please help commit this for me.

Thanks,

This revision was automatically updated to reflect the committed changes.

Very useful contribution. Thank you!