This is an archive of the discontinued LLVM Phabricator instance.

Differential D6672

Add parsing of 'foo@local".
ClosedPublic

Authored by jhibbits on Dec 15 2014, 6:21 PM.

Download Raw Diff

Details

Reviewers

hfinkel

Commits

rG0c0d5deff1d6: Add parsing of 'foo@local".
rL224415: Add parsing of 'foo@local".

Summary

Currently, it supports generating, but not parsing, this expression.
Test added as well.

Diff Detail

Event Timeline

jhibbits updated this revision to Diff 17315.Dec 15 2014, 6:21 PM

jhibbits retitled this revision from to Add parsing of 'foo@local"..

jhibbits updated this object.

jhibbits edited the test plan for this revision. (Show Details)

jhibbits added a reviewer: hfinkel.

jhibbits added a subscriber: Unknown Object (MLST).

LGTM.

This revision is now accepted and ready to land.Dec 16 2014, 12:05 PM

Closed by commit rL224415: Add parsing of 'foo@local". (authored by jhibbits). · Explain WhyDec 16 2014, 10:24 PM

This revision was automatically updated to reflect the committed changes.

Do you want the upper-case variant as well? i.e., foo@LOCAL? That would match the other entries in the switch.

In D6672#102521, @grosbach wrote:

Do you want the upper-case variant as well? i.e., foo@LOCAL? That would match the other entries in the switch.

Good eye. I had made the change for another local branch, but didn't add it to this apparently. I'll go ahead and add it.

Revision Contents

Path

Size

lib/

MC/

MCExpr.cpp

1 line

test/

MC/

PowerPC/

ppc-reloc.s

2 lines

Diff 17315

lib/MC/MCExpr.cpp

Show First 20 Lines • Show All 347 Lines • ▼ Show 20 Lines	return StringSwitch<VariantKind>(Name)
.Case("HIGHESTA", VK_PPC_HIGHESTA)		.Case("HIGHESTA", VK_PPC_HIGHESTA)
.Case("highesta", VK_PPC_HIGHESTA)		.Case("highesta", VK_PPC_HIGHESTA)
.Case("GOT@L", VK_PPC_GOT_LO)		.Case("GOT@L", VK_PPC_GOT_LO)
.Case("got@l", VK_PPC_GOT_LO)		.Case("got@l", VK_PPC_GOT_LO)
.Case("GOT@H", VK_PPC_GOT_HI)		.Case("GOT@H", VK_PPC_GOT_HI)
.Case("got@h", VK_PPC_GOT_HI)		.Case("got@h", VK_PPC_GOT_HI)
.Case("GOT@HA", VK_PPC_GOT_HA)		.Case("GOT@HA", VK_PPC_GOT_HA)
.Case("got@ha", VK_PPC_GOT_HA)		.Case("got@ha", VK_PPC_GOT_HA)
		.Case("local", VK_PPC_LOCAL)
.Case("TOCBASE", VK_PPC_TOCBASE)		.Case("TOCBASE", VK_PPC_TOCBASE)
.Case("tocbase", VK_PPC_TOCBASE)		.Case("tocbase", VK_PPC_TOCBASE)
.Case("TOC", VK_PPC_TOC)		.Case("TOC", VK_PPC_TOC)
.Case("toc", VK_PPC_TOC)		.Case("toc", VK_PPC_TOC)
.Case("TOC@L", VK_PPC_TOC_LO)		.Case("TOC@L", VK_PPC_TOC_LO)
.Case("toc@l", VK_PPC_TOC_LO)		.Case("toc@l", VK_PPC_TOC_LO)
.Case("TOC@H", VK_PPC_TOC_HI)		.Case("TOC@H", VK_PPC_TOC_HI)
.Case("toc@h", VK_PPC_TOC_HI)		.Case("toc@h", VK_PPC_TOC_HI)
▲ Show 20 Lines • Show All 504 Lines • Show Last 20 Lines

test/MC/PowerPC/ppc-reloc.s

	# RUN: llvm-mc -triple=powerpc-unknown-linux-gnu -filetype=obj %s \| \			# RUN: llvm-mc -triple=powerpc-unknown-linux-gnu -filetype=obj %s \| \
	# RUN: llvm-readobj -r \| FileCheck %s			# RUN: llvm-readobj -r \| FileCheck %s
	.section .text			.section .text

	.globl foo			.globl foo
	.type foo,@function			.type foo,@function
	.align 2			.align 2
	foo:			foo:
	bl printf@plt			bl printf@plt
				bl _GLOBAL_OFFSET_TABLE_@local-4
	.LC1:			.LC1:
	.size foo, . - foo			.size foo, . - foo

	# CHECK: Relocations [			# CHECK: Relocations [
	# CHECK-NEXT: Section (2) .rela.text {			# CHECK-NEXT: Section (2) .rela.text {
	# CHECK-NEXT: 0x0 R_PPC_PLTREL24 printf 0x0			# CHECK-NEXT: 0x0 R_PPC_PLTREL24 printf 0x0
				# CHECK-NEXT: 0x4 R_PPC_LOCAL24PC _GLOBAL_OFFSET_TABLE_ 0xFFFFFFFC
	# CHECK-NEXT: }			# CHECK-NEXT: }
	# CHECK-NEXT: ]			# CHECK-NEXT: ]