Page MenuHomePhabricator

Add parsing of 'foo@local".
ClosedPublic

Authored by jhibbits on Dec 15 2014, 6:21 PM.

Details

Summary

Currently, it supports generating, but not parsing, this expression.
Test added as well.

Diff Detail

Repository
rL LLVM

Event Timeline

jhibbits updated this revision to Diff 17315.Dec 15 2014, 6:21 PM
jhibbits retitled this revision from to Add parsing of 'foo@local"..
jhibbits updated this object.
jhibbits edited the test plan for this revision. (Show Details)
jhibbits added a reviewer: hfinkel.
jhibbits added a subscriber: Unknown Object (MLST).
hfinkel accepted this revision.Dec 16 2014, 12:05 PM
hfinkel edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 16 2014, 12:05 PM
This revision was automatically updated to reflect the committed changes.

Do you want the upper-case variant as well? i.e., foo@LOCAL? That would match the other entries in the switch.

Do you want the upper-case variant as well? i.e., foo@LOCAL? That would match the other entries in the switch.

Good eye. I had made the change for another local branch, but didn't add it to this apparently. I'll go ahead and add it.