[clang-format] Support .mjs module javascript extension in clang-format

[fergald]

Summary

PR43085.

Recognize .mjs files as JavaScript. .mjs is the extension used by Node.js for ECMAScript modules. A specific extension (and associated content type javascript/esm) is introduced to differentiate it from previous CommonJS modules and solve some interoperability problems.

[thakis]

Does clang-format format import and export lines in mjs files correctly?

[fergald]

It seems to do the right thing. E.g.

https://crrev.com/c/1767284/5/third_party/blink/renderer/core/script/resources/layered_api/elements/virtual-scroller/visibility-manager.mjs

[fergald]

I cannot commit this, please do so, if you're happy with it.

[MaskRay]

This causes .mjs files to be treated as javascript.

I think you meant .mjs was not recognized before but will be recognized as JavaScript with this change.

Can you elaborate a bit why .mjs is so common that it justifies a clang-format change?

[MaskRay]

module-javascript. Module javascript is not compatible with non-module java script as it uses the "export" and "import" keywords which are only legal in module-javascript.

java script -> JavaScript
module-javascript -> Module JavaScript?

[fergald]

"why .mjs is so common that it justifies a clang-format change?"

I don't have data but Module JS is the future, it's supported by all major browsers for some time and also Node.js, it solves the problem of everything being lumped into one namespace.

Why does it need a different suffix? It adds the "export" and "import" keywords and so it incompatible with common JS. Forcing everyone to keep using js for both is not helpful (clang-format is not forcing of course but applying clang-format with --assume-filename is pretty awkward).

Node specifies .mjs as the suffix

https://medium.com/@nodejs/announcing-a-new-experimental-modules-1be8d2d6c2ff
https://nodejs.org/api/esm.html

So the use of the .mjs suffix is going to grow in volume as people modernize their project. It would be great for clang-format to be enabling that migration.

[MaskRay]

Reading some materials online... I think this should be named ECMAScript module (ECM), not JavaScript modules.. I can fix the description and commit for you.

How about this description?

Recognize .mjs files as JavaScript. .mjs is the extension used by Node.js for ECMAScript modules. A specific extension (and associated content type javascript/esm) is
introduced to differentiate it from previous CommonJS modules and solve some
interoperability problems.

[fergald]

Thanks, I'm happy with that description

cfe/trunk/lib/Format/Format.cpp

const char *StyleOptionHelpDescription =
     "directory for stdin).\n"
     "Use -style=\"{key: value, ...}\" to set specific\n"
     "parameters, e.g.:\n"
     "  -style=\"{BasedOnStyle: llvm, IndentWidth: 8}\"";
 
 static FormatStyle::LanguageKind getLanguageByFileName(StringRef FileName) {
   if (FileName.endswith(".java"))
     return FormatStyle::LK_Java;
-  if (FileName.endswith_lower(".js") || FileName.endswith_lower(".ts"))
-    return FormatStyle::LK_JavaScript; // JavaScript or TypeScript.
+  if (FileName.endswith_lower(".js") || FileName.endswith_lower(".mjs") ||
+      FileName.endswith_lower(".ts"))
+    return FormatStyle::LK_JavaScript; // (module) JavaScript or TypeScript.
   if (FileName.endswith(".m") || FileName.endswith(".mm"))
     return FormatStyle::LK_ObjC;
   if (FileName.endswith_lower(".proto") ||
       FileName.endswith_lower(".protodevel"))
     return FormatStyle::LK_Proto;
   if (FileName.endswith_lower(".textpb") ||
       FileName.endswith_lower(".pb.txt") ||
       FileName.endswith_lower(".textproto") ||