Page MenuHomePhabricator

[clang][IFS] Adding new Interface Stubs format.
ClosedPublic

Authored by plotfi on Aug 19 2019, 3:11 PM.

Details

Summary

After posting llvm-ifs, I made some progress in hardening up how I think the format for Interface Stubs should look.
There are a number of things I think the TBE format was missing (no endianness, no info about the Object Format because it assumes ELF), so I have added those and broken off from being as similar to the TBE schema. I think in a subsequent commit I can drop the other formats.

Diff Detail

Repository
rL LLVM

Event Timeline

plotfi created this revision.Aug 19 2019, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2019, 3:11 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
plotfi marked an inline comment as done.Aug 19 2019, 3:12 PM
plotfi added inline comments.
clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
363 ↗(On Diff #216001)

This is missing ObjectFileFormat: ELF

plotfi updated this revision to Diff 216004.Aug 19 2019, 3:17 PM

Adding ObjectFileFormat

compnerd accepted this revision.Aug 22 2019, 10:15 AM

Please add a test case for read/write, otherwise LGTM.

clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
383 ↗(On Diff #216004)

Why is this comma separated rather than a separate value?

392 ↗(On Diff #216004)

Why comma separated rather than new KV pair?

This revision is now accepted and ready to land.Aug 22 2019, 10:15 AM
plotfi marked 4 inline comments as done.Aug 22 2019, 10:25 AM
plotfi added inline comments.
clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp
383 ↗(On Diff #216004)

Vestiges of TBE elfabi inspiration. It can change in experimental-ifs-v2 / 1.1 or something.

392 ↗(On Diff #216004)

Vestiges of TBE elfabi inspiration. It can change in experimental-ifs-v2 / 1.1 or something.

plotfi marked 2 inline comments as done.Aug 22 2019, 10:25 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2019, 4:30 PM