Page MenuHomePhabricator

[util] Add check to git-llvm to avoid pushing to a non-trunk branch
Needs ReviewPublic

Authored by aykevl on Aug 18 2019, 11:38 AM.

Details

Summary

To prevent pushing to a release branch by accident, for example. This happened to me in https://reviews.llvm.org/D66379 and I'd like to make sure this doesn't happen again - at least for newer LLVM releases.

The cause was most likely that my git-llvm binary was pointing to a checkout that used to be at master but was switched to release_80, which meant that while I pushed from the master branch, it was actually pushing to release_80 due to the wrong version of git-llvm.

Diff Detail

Event Timeline

aykevl created this revision.Aug 18 2019, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2019, 11:38 AM
hans edited reviewers, added: mehdi_amini, jyknight; removed: hans.Aug 20 2019, 2:12 AM

I don't really know this script. I think Mehdi or James might be better reviewers.

LLVM_MONOREPO_DIR = '/trunk'

Can this be a option (default setting: trunk) ?