Page MenuHomePhabricator

Add LLDB dataformatters for llvm::StringRef and lldb_private::ConstString
ClosedPublic

Authored by aprantl on Aug 16 2019, 9:51 AM.

Details

Summary

These data formatters make the string value appear in Xcode's variables view (and on the command line) without having to expand the data structure.

Diff Detail

Repository
rL LLVM

Event Timeline

aprantl created this revision.Aug 16 2019, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2019, 9:51 AM

I don't think you need to go back and cover all the ones already added, but could we start adding tests for new lldb/llvm data formatters as we add them? That way we can keep them useful as people change llvm.

LGTM. It would be great if we can add a test.

It's not quite obvious to me how to write a test for this. The test would need to live in LLDB, and it would need to compile a program linking against a variant of libSupport that was compiled with debug info. I'm not sure how to best do this.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2019, 4:46 PM
This revision was automatically updated to reflect the committed changes.